Fix the "Add ring" map tool / QgsVectorLayerEditUtils::addRingV2 (Fix #59053) #59066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
Not sure why "cppcheck" check failed and if the fail is actually due to changes introduced by this PR. |
|
Does not seem related to your PR. |
lbartoletti
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression in the "Add ring" map tool (since QGIS 3.28, #50447), which incorrectly prevents to add a ring to a feature's geometry when the ring's bounding box intersects more then 1 feature's geometry, or when there are more then 1 features selected, and the ring can be added only to a subset of such features in some circumstances.
Fixes #59053.