-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[network] Implement a smart cache size #58548
Conversation
dfcc3dc
to
0544092
Compare
5ac8bea
to
73efe05
Compare
73efe05
to
f8450ad
Compare
@rouault , @nyalldawson , @DelazJ , thanks for the reviews, points have been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nirvn Looks fine regarding my requests.
2629554
to
e8ce6a6
Compare
e8ce6a6
to
f0085c6
Compare
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
@nirvn A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
@nirvn |
Description
This PR improves QGIS' handling of its network disk cache by using a smart cache size logic that dynamically sizes based on the disk cache storage's available space. The logic is taken from Firefox (https://github.com/mozilla/gecko-dev/blob/e0a62f1391f7d58fab20418adc9310b23708a792/netwerk/cache2/CacheFileIOManager.cpp#L4307), and will results in most users getting a larger cache size.
The objective here is to insure that our default cache size insures we are as friendly as we can to servers hosting XYZ tiles, incl. but not limited to OpenStreetMap.
Users can disable the smart cache size logic in favor of a static cache size in the Options dialog. On that front, the spin box represents MBs instead of KiBs, because we're in 2024 :)