Externalize nlohmann #57935
Merged
Externalize nlohmann #57935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
approved these changes
Jun 29, 2024
|
@m-kuhn is it worth switching either the qt5 or qt6 ci build to use the system library? (So that we get test coverage of both setups) |
|
Will be done with vcpkg #57414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nlohmann_json is used in many different styles throughout the codebase. This cleans things up and makes it possible to use a system provided copy.
Adds a new cmake flag
WITH_INTERNAL_NLOHMANN_JSONwhich is enabled by default for backwards compatibility.