Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reclassify Table changes are lost when pressing lower OK in Modeler #60442

Closed
2 tasks done
baswein opened this issue Feb 4, 2025 · 0 comments · Fixed by #60551
Closed
2 tasks done

Reclassify Table changes are lost when pressing lower OK in Modeler #60442

baswein opened this issue Feb 4, 2025 · 0 comments · Fixed by #60551
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@baswein
Copy link
Contributor

baswein commented Feb 4, 2025

What is the bug or the crash?

When working in the Modeler with the Reclassify by Table tool when editing the reclassification table the dialog has two OK buttons.
The OK button on the right side saves the changes to the table while the OK button in the bottom (which is for the whole tool) closes the tool and does not save the changes to the table.
This has caused me some issues in the past and watched a number of students struggle with this today.
This seems to be a similar issue to this problem #47602 and this fix #51137

Steps to reproduce the issue

  1. Create new model
  2. Add Reclassify by Table Algorithm
  3. Edit Reclassification table
  4. Press OK at the bottom
  5. Reopen Reclassify by Table Algorithm
  6. See that the table changes have not been saved.

Versions

<style type="text/css"> p, li { white-space: pre-wrap; } </style>
QGIS version 3.41.0-Master
QGIS code revision 0459679
 
Libraries
Qt version 5.15.13
Python version 3.12.8
GDAL/OGR version 3.11.0dev-7ed21aa088
PROJ version 9.5.1
EPSG Registry database version v11.022 (2024-11-05)
GEOS version 3.13.0-CAPI-1.19.0
SQLite version 3.46.1
PDAL version 2.8.3
PostgreSQL client version unknown
SpatiaLite version 5.1.0
QWT version 6.3.0
QScintilla2 version 2.14.1
OS version Windows 11 Version 2009
This copy of QGIS writes debugging output.
 
Active Python plugins
db_manager 0.1.20
grassprovider 2.12.99
processing 2.12.99
QGIS version 3.41.0-Master QGIS code revision [0459679](https://github.com/qgis/QGIS/commit/0459679c4b)

Libraries
Qt version
5.15.13
Python version
3.12.8
GDAL/OGR version
3.11.0dev-7ed21aa088
PROJ version
9.5.1
EPSG Registry database version
v11.022 (2024-11-05)
GEOS version
3.13.0-CAPI-1.19.0
SQLite version
3.46.1
PDAL version
2.8.3
PostgreSQL client version
unknown
SpatiaLite version
5.1.0
QWT version
6.3.0
QScintilla2 version
2.14.1
OS version
Windows 11 Version 2009
This copy of QGIS writes debugging output.

Active Python plugins
db_manager
0.1.20
grassprovider
2.12.99
processing
2.12.99

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

Additional context

No response

@baswein baswein added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Feb 4, 2025
@Djedouas Djedouas assigned Djedouas and unassigned Djedouas Feb 11, 2025
nyalldawson added a commit to nyalldawson/QGIS that referenced this issue Feb 12, 2025
When an algorithm is run and the editor panel is still open
for a matrix parameter, use the table defined in that panel
as for the parameter.

Fixes qgis#60442
qgis-bot pushed a commit that referenced this issue Feb 12, 2025
When an algorithm is run and the editor panel is still open
for a matrix parameter, use the table defined in that panel
as for the parameter.

Fixes #60442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants