Merge pull request #57918 from nyalldawson/auth_errors

Avoid some misleading ssl/auth errors in console output
qgis · Jun 28, 2024 · e27b126 · e27b126
2 parents b578f1e + 0579df4
commit e27b126
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/app/qgsappsslerrorhandler.cpp b/src/app/qgsappsslerrorhandler.cpp
@@ -25,8 +25,6 @@ void QgsAppSslErrorHandler::handleSslErrors( QNetworkReply *reply, const QList<Q
 {
   Q_ASSERT( QThread::currentThread() == QApplication::instance()->thread() );
 
-  QgsDebugError( QStringLiteral( "SSL errors occurred accessing URL:\n%1" ).arg( reply->request().url().toString() ) );
-
   const QString hostport( QStringLiteral( "%1:%2" )
                           .arg( reply->url().host() )
                           .arg( reply->url().port() != -1 ? reply->url().port() : 443 )
@@ -65,6 +63,8 @@ void QgsAppSslErrorHandler::handleSslErrors( QNetworkReply *reply, const QList<Q
                             hostport ), 2 );
   }
 
+  QgsDebugError( QStringLiteral( "SSL errors occurred accessing URL:\n%1" ).arg( reply->request().url().toString() ) );
+
   QgsAuthSslErrorsDialog *dlg = new QgsAuthSslErrorsDialog( reply, errors, QgisApp::instance(), digest, hostport );
   dlg->setWindowModality( Qt::ApplicationModal );
   dlg->resize( 580, 512 );

diff --git a/src/core/auth/qgsauthmanager.cpp b/src/core/auth/qgsauthmanager.cpp
@@ -1704,7 +1704,7 @@ bool QgsAuthManager::updateNetworkReply( QNetworkReply *reply, const QString &au
   {
     if ( !( authmethod->supportedExpansions() & QgsAuthMethod::NetworkReply ) )
     {
-      QgsDebugError( QStringLiteral( "Network reply updating not supported by authcfg: %1" ).arg( authcfg ) );
+      QgsDebugMsgLevel( QStringLiteral( "Network reply updating not supported by authcfg: %1" ).arg( authcfg ), 3 );
       return true;
     }