Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: renew shortcuts profiles icons and add versions compatible with QGIS profiles list #453

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Mar 21, 2024

For now, we use the same icon for both examples profiles (Viewer Mode and demo) which is in fact the QDT logo made by @sylvainbeo.

We need a different icon per profile that evokes the QDT logo. Icon is used at 2 places:

  • for the desktop/start menu entry
  • in the QGIS profiles list. This one is quite challenging regarding the size:

image

The icon can be slightly different for the two uses.

Related to: #448

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 21, 2024
@sylvainbeo
Copy link
Contributor

@Guts See my propositions

@Guts
Copy link
Collaborator Author

Guts commented Mar 22, 2024

I like this simple but efficient idea. Nice job @sylvainbeo!

Can you:

  • create the third one following the same principle? this way, we'll get it for an eventual future 3rd profile
  • push svg version
  • push png but bigger version

@sylvainbeo
Copy link
Contributor

Done, except for the thirs icon. I prefer to wait for a third profile.

@github-actions github-actions bot added the jobs Scenarios and jobs label Mar 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.11%. Comparing base (57b7a93) to head (45822ce).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   71.11%   71.11%           
=======================================
  Files          45       45           
  Lines        2645     2645           
  Branches      569      569           
=======================================
  Hits         1881     1881           
  Misses        583      583           
  Partials      181      181           
Flag Coverage Δ
unittests 70.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
qgis_deployment_toolbelt/jobs/job_shortcuts.py 56.52% <100.00%> (ø)

@Guts Guts removed the jobs Scenarios and jobs label Mar 22, 2024
@Guts Guts changed the title demo: add profiles icons demo: renew shortcuts profiles icons and add versions compatible with QGIS profiles list Mar 22, 2024
@Guts Guts merged commit 145d2bc into main Mar 22, 2024
25 checks passed
@Guts Guts deleted the demo/add-profiles-icon branch March 22, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants