Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto: remove unused methods and improve doctsrings #429

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Feb 22, 2024

No description provided.

@Guts Guts requested a review from Ducarouge February 22, 2024 11:39
@github-actions github-actions bot added the jobs Scenarios and jobs label Feb 22, 2024
@Guts Guts self-assigned this Feb 22, 2024
@Guts Guts force-pushed the refacto/cleanup-orchestrator branch from eac5b63 to b84ccb5 Compare February 22, 2024 11:54
@Guts Guts force-pushed the refacto/cleanup-orchestrator branch from b84ccb5 to 46b884a Compare February 22, 2024 14:18
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (68bcbc2) 69.90% compared to head (46b884a) 69.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   69.90%   69.91%   +0.01%     
==========================================
  Files          43       43              
  Lines        2462     2453       -9     
  Branches      525      524       -1     
==========================================
- Hits         1721     1715       -6     
+ Misses        575      571       -4     
- Partials      166      167       +1     
Flag Coverage Δ
unittests 69.34% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
qgis_deployment_toolbelt/jobs/orchestrator.py 90.00% <83.33%> (+5.38%) ⬆️

@Guts Guts merged commit f71a6d8 into main Feb 22, 2024
25 checks passed
@Guts Guts deleted the refacto/cleanup-orchestrator branch February 22, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jobs Scenarios and jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants