-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto: factorize logs folders retrieval #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a remark for logs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 71.28% 71.45% +0.16%
==========================================
Files 43 43
Lines 2448 2452 +4
Branches 521 522 +1
==========================================
+ Hits 1745 1752 +7
+ Misses 526 524 -2
+ Partials 177 176 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion for correct folder use in logs and it's good !
Co-authored-by: jmkerloch <53606373+jmkerloch@users.noreply.github.com> Signed-off-by: Julien <dev@ingeoveritas.com>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Thanks @jmkerloch for your attentive review, really appreciated! |
No description provided.