Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac arm64 support #1425

Closed
wants to merge 12 commits into from
Closed

mac arm64 support #1425

wants to merge 12 commits into from

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Mar 1, 2024

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (d99cbc0) to head (3fe0983).
Report is 6 commits behind head on master.

❗ Current head 3fe0983 differs from pull request most recent head e16a489. Consider uploading reports for the commit e16a489 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   95.14%   95.06%   -0.08%     
==========================================
  Files         612      609       -3     
  Lines       22677    22509     -168     
  Branches     3637     3652      +15     
==========================================
- Hits        21576    21399     -177     
- Misses        616      624       +8     
- Partials      485      486       +1     
Flag Coverage Δ
all 95.06% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qdraw qdraw linked an issue Mar 1, 2024 that may be closed by this pull request
@qdraw qdraw changed the title change default build options mac arm64 support Mar 2, 2024
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@qdraw qdraw closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop Mac OS and new pipeline
1 participant