Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoisted CSF annotations #1397

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Feb 19, 2024

Storybook 6 introduces hoisted CSF annotations and deprecates the StoryFn.story object-style annotation.

https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#hoisted-csf-annotations

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

Storybook 6 introduces hoisted CSF annotations and deprecates the StoryFn.story object-style annotation.

https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#hoisted-csf-annotations
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c59ac9) 95.32% compared to head (dca7c0e) 95.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
- Coverage   95.32%   95.31%   -0.02%     
==========================================
  Files         586      586              
  Lines       22364    22364              
  Branches     4068     4088      +20     
==========================================
- Hits        21319    21316       -3     
- Misses        655      658       +3     
  Partials      390      390              
Flag Coverage Δ
all 95.31% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@qdraw qdraw merged commit cb0bb14 into master Feb 19, 2024
13 checks passed
@qdraw qdraw deleted the feature/202402-hoisted-csf-annotations branch February 19, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant