Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry #1323

Merged
merged 21 commits into from
Jan 8, 2024
Merged

OpenTelemetry #1323

merged 21 commits into from
Jan 8, 2024

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Dec 29, 2023

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (81d49a7) 94.77% compared to head (d1bcf04) 94.77%.
Report is 22 commits behind head on master.

Files Patch % Lines
....webtelemetry/Extensions/OpenTelemetryExtension.cs 95.00% 0 Missing and 3 partials ⚠️
...ation.platform/Helpers/AppSettingsCompareHelper.cs 94.44% 0 Missing and 1 partial ⚠️
...oundation.platform/Models/OpenTelemetrySettings.cs 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1323    +/-   ##
========================================
  Coverage   94.77%   94.77%            
========================================
  Files         576      579     +3     
  Lines       20298    20437   +139     
  Branches     3165     3187    +22     
========================================
+ Hits        19238    19370   +132     
- Misses        693      695     +2     
- Partials      367      372     +5     
Flag Coverage Δ
all 94.77% <96.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 8, 2024

@qdraw qdraw merged commit ad3246c into master Jan 8, 2024
19 checks passed
@qdraw qdraw deleted the feature/202312_open_telemetry branch January 8, 2024 20:25
@qdraw qdraw linked an issue Jan 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry instead of Application Insights
1 participant