code smells

starsky/Dockerfile

@@ -48,7 +48,7 @@ RUN rm /app/global.json
 
 RUN \
     if [ "$TARGETPLATFORM" = "linux/amd64" ]; then \
-        echo $TARGETPLATFORM ; \
+        echo "$TARGETPLATFORM" ; \
         dotnet restore --runtime linux-x64 starsky.csproj ; \
     elif [ "$TARGETPLATFORM" = "linux/arm64" ]; then \
         dotnet restore --runtime linux-arm64 starsky.csproj ; \
@@ -85,9 +85,9 @@ RUN \
         DEMO_SEED_CLI_PATH="/app/starskydemoseedcli/starskydemoseedcli.csproj" ;\
         DEPS_FOLDER="/app/dependencies" ;\
         TEMP_FOLDER="/app/temp" ;\
-        mkdir -p $DEPS_FOLDER ;\
-        mkdir -p $TEMP_FOLDER ;\
-        dotnet run --project $DEMO_SEED_CLI_PATH --configuration Release -- --dependencies $DEPS_FOLDER --tempfolder $TEMP_FOLDER -h -v ;\
+        mkdir -p "$DEPS_FOLDER" ;\
+        mkdir -p "$TEMP_FOLDER" ;\
+        dotnet run --project "$DEMO_SEED_CLI_PATH" --configuration Release -- --dependencies "$DEPS_FOLDER" --tempfolder "$TEMP_FOLDER" -h -v ;\
     fi
 
 # no alpine build since there is no support for multi-arch
@@ -101,7 +101,7 @@ WORKDIR /app
 RUN if [ "$TEST" = "true" ]; then \
         mkdir -p "/testresults" ;\
         if [ "$BUILDPLATFORM" = "$TARGETPLATFORM" ]; then \
-          echo $TEST $BUILDPLATFORM $TARGETPLATFORM ; \
+          echo "$TEST" "$BUILDPLATFORM" "$TARGETPLATFORM" ; \
           dotnet test -c release --results-directory /testresults --logger "trx;LogFileName=test_results.trx" --collect:"XPlat Code Coverage" --settings build.vstest.runsettings starskytest/starskytest.csproj ; \
         fi ;\
         touch "/testresults/test.enabled" ;\

starsky/starsky.feature.health/UpdateCheck/Services/CheckForUpdates.cs

@@ -1,3 +1,4 @@
+#nullable enable
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -20,11 +21,11 @@ public class CheckForUpdates : ICheckForUpdates
 	{
 		internal const string GithubApi = "https://api.github.com/repos/qdraw/starsky/releases";
 
-		private readonly AppSettings _appSettings;
-		private readonly IMemoryCache _cache;
+		private readonly AppSettings? _appSettings;
+		private readonly IMemoryCache? _cache;
 		private readonly IHttpClientHelper _httpClientHelper;
 
-		public CheckForUpdates(IHttpClientHelper httpClientHelper, AppSettings appSettings, IMemoryCache cache)
+		public CheckForUpdates(IHttpClientHelper httpClientHelper, AppSettings? appSettings, IMemoryCache? cache)
 		{
 			_httpClientHelper = httpClientHelper;
 			_appSettings = appSettings;
@@ -47,31 +48,36 @@ public async Task<KeyValuePair<UpdateStatus, string>> IsUpdateNeeded(string curr
 				?  _appSettings.AppVersion : currentVersion;
 
 			// The CLI programs uses no cache
-			if( _cache == null || _appSettings?.AddMemoryCache == false) 
+			if ( _cache == null || _appSettings?.AddMemoryCache == false )
+			{
 				return Parse(await QueryIsUpdateNeededAsync(),currentVersion);
+			}
 
-			if ( _cache.TryGetValue(QueryCheckForUpdatesCacheName, out var cacheResult) )
+			if (  _cache.TryGetValue(QueryCheckForUpdatesCacheName,
+				    out var cacheResult) )
+			{
 				return Parse(( List<ReleaseModel> ) cacheResult, currentVersion);
+			}
 
 			cacheResult = await QueryIsUpdateNeededAsync();
 
 			_cache.Set(QueryCheckForUpdatesCacheName, cacheResult, 
-			new TimeSpan(48,0,0));
+				new TimeSpan(48,0,0));
 
-			return Parse(( List<ReleaseModel> ) cacheResult,currentVersion);
+			return Parse(( List<ReleaseModel>? ) cacheResult,currentVersion);
 		}
 
-		internal async Task<List<ReleaseModel>> QueryIsUpdateNeededAsync()
+		internal async Task<List<ReleaseModel>?> QueryIsUpdateNeededAsync()
 		{
 			// argument check is done in QueryIsUpdateNeeded
 			var (key, value) = await _httpClientHelper.ReadString(GithubApi);
 			return !key ? new List<ReleaseModel>() : JsonSerializer.Deserialize<List<ReleaseModel>>(value, new JsonSerializerOptions());
 		}
-
-		internal static KeyValuePair<UpdateStatus, string> Parse(IEnumerable<ReleaseModel> releaseModelList, string currentVersion )
+		
+		internal static KeyValuePair<UpdateStatus, string> Parse(IEnumerable<ReleaseModel>? releaseModelList, string currentVersion )
 		{
-			var orderedReleaseModelList = releaseModelList.OrderByDescending(p => p.TagName);
-			var tagName = orderedReleaseModelList.FirstOrDefault(p => !p.Draft && !p.PreRelease)?.TagName;
+			var orderedReleaseModelList = releaseModelList?.OrderByDescending(p => p.TagName);
+			var tagName = orderedReleaseModelList?.FirstOrDefault(p => p is { Draft: false, PreRelease: false })?.TagName;
 			if ( string.IsNullOrWhiteSpace(tagName) ||
 			     !tagName.StartsWith('v') )
 			{

starsky/starsky.feature.search/ViewModels/SearchViewModel.cs

@@ -426,7 +426,8 @@ public string ParseDefaultOption(string defaultQuery)
 			return returnQueryBuilder.ToString();
 		}
 
-		private (string defaultQuery, StringBuilder returnQueryBuilder) ParseQuotedValues(string defaultQuery, StringBuilder returnQueryBuilder)
+		private (string defaultQuery, StringBuilder returnQueryBuilder) 
+			ParseQuotedValues(string defaultQuery, StringBuilder returnQueryBuilder)
 		{
 			// Get Quoted values
 			// (["'])(\\?.)*?\1
@@ -535,7 +536,7 @@ public static SearchViewModel NarrowSearch(SearchViewModel model)
 			return model;
 		}
 
-		private static SearchViewModel PropertySearchStringType(
+		internal static SearchViewModel PropertySearchStringType(
 			SearchViewModel model,
 			PropertyInfo property, string searchForQuery,
 			SearchForOptionType searchType)
@@ -546,27 +547,37 @@ private static SearchViewModel PropertySearchStringType(
 					model.FileIndexItems = model.FileIndexItems!.Where(
 						p => p.GetType().GetProperty(property.Name)?.Name == property.Name 
 						     && ! // not
-							     p.GetType().GetProperty(property.Name)!.GetValue(p, null)!
-								     .ToString()!.ToLowerInvariant().Contains(searchForQuery)  
+							     p.GetType().GetProperty(property.Name)!.GetValue(p, null)?
+								     .ToString()?.ToLowerInvariant().Contains(searchForQuery)  == true
 					).ToList();
 					break;
 				default:
-					model.FileIndexItems = model.FileIndexItems!
+					model.FileIndexItems = model.FileIndexItems?
 						.Where(p => p.GetType().GetProperty(property.Name)?.Name == property.Name 
-						            && p.GetType().GetProperty(property.Name)!.GetValue(p, null)!
-							            .ToString()!.ToLowerInvariant().Contains(searchForQuery)  
+						            && p.GetType().GetProperty(property.Name)!.GetValue(p, null)?
+							            .ToString()?.ToLowerInvariant().Contains(searchForQuery) == true  
 						).ToList();
 					break;
 			}
 
 			return model;
 		}
 
-		private static SearchViewModel PropertySearchBoolType(
-			SearchViewModel model,
-			PropertyInfo property, bool boolIsValue)
+		internal static SearchViewModel PropertySearchBoolType(
+			SearchViewModel? model,
+			PropertyInfo? property, bool boolIsValue)
 		{
-			model.FileIndexItems = model.FileIndexItems!
+			if ( model == null )
+			{
+				return new SearchViewModel();
+			}
+
+			if ( property == null)
+			{
+				return model;
+			}
+
+			model.FileIndexItems = model.FileIndexItems?
 				.Where(p => p.GetType().GetProperty(property.Name)?.Name == property.Name 
 				            && (bool?) p.GetType().GetProperty(property.Name)?.GetValue(p, null)  == boolIsValue
 				).ToList();
@@ -653,12 +664,14 @@ internal static SearchViewModel PropertySearch(SearchViewModel model,
 				return PropertySearchStringType(model, property, searchForQuery, searchType);
 			}
 
-			if ( property.PropertyType == typeof(bool) && bool.TryParse(searchForQuery, out var boolIsValue))
+			if ( (property.PropertyType == typeof(bool) || property.PropertyType == typeof(bool?)) && 
+			     bool.TryParse(searchForQuery, out var boolIsValue))
 			{
 				return PropertySearchBoolType(model, property, boolIsValue);
 			}
 
-			if ( property.PropertyType == typeof(ExtensionRolesHelper.ImageFormat) && Enum.TryParse<ExtensionRolesHelper.ImageFormat>(
+			if ( property.PropertyType == typeof(ExtensionRolesHelper.ImageFormat) && 
+			     Enum.TryParse<ExtensionRolesHelper.ImageFormat>(
 				    searchForQuery.ToLowerInvariant(), out var castImageFormat) )
 			{
 				return PropertySearchImageFormatType(model, property, castImageFormat, searchType);				

starsky/starsky.foundation.database/Helpers/SetupDatebaseTypes.cs

@@ -116,7 +116,7 @@ public void BuilderDb(string? foundationDatabaseName = "")
 			if ( _logger != null && _appSettings.IsVerbose() )
 			{
 				_logger.LogInformation($"Database connection: {_appSettings.DatabaseConnection}");
-				_logger?.LogInformation($"Application Insights Database tracking is {IsDatabaseTrackingEnabled()}" );
+				_logger.LogInformation($"Application Insights Database tracking is {IsDatabaseTrackingEnabled()}" );
 			}
 
 #if ENABLE_DEFAULT_DATABASE

starsky/starsky.foundation.database/Models/FileIndexItem.cs

@@ -481,7 +481,8 @@ public static List<string> FileIndexPropList()
 			var fileIndexPropList = new List<string>();
 			// only for types String in FileIndexItem()
 
-			foreach (var propertyInfo in new FileIndexItem().GetType().GetProperties())
+			var allProperties = new FileIndexItem().GetType().GetProperties();
+			foreach (var propertyInfo in allProperties)
 			{
 				if ((
 					propertyInfo.PropertyType == typeof(bool) || 

starsky/starsky.foundation.readmeta/ReadMetaHelpers/ReadMetaXmp.cs

@@ -136,7 +136,7 @@ private static FileIndexItem GetDataNullNameSpaceTypes(IXmpMeta xmp, FileIndexIt
                      !string.IsNullOrEmpty(property.Value) && 
                      string.IsNullOrEmpty(property.Namespace) )
                 {
-                    StringBuilder tagsStringBuilder = new StringBuilder();
+                    var tagsStringBuilder = new StringBuilder();
                     tagsStringBuilder.Append(item.Tags);
                     tagsStringBuilder.Append(", ");
                     tagsStringBuilder.Append(property.Value);

starsky/starsky/clientapp/package.json

@@ -8,8 +8,8 @@
     "start": "vite --port 3000",
     "build": "tsc -p tsconfig.prod.json && vite build",
     "spell": "cspell --config cspell.json \"src/**/*.{ts,tsx,js,md}\" --exclude build",
-    "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 800",
-    "lint:fix": "eslint --fix . --ext ts,tsx --report-unused-disable-directives --max-warnings 800",
+    "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 810",
+    "lint:fix": "eslint --fix . --ext ts,tsx --report-unused-disable-directives --max-warnings 810",
     "format": "prettier --write './**/*.{js,jsx,ts,tsx,css,md,json}'",
     "test": "jest --watch",
     "test:ci": "jest --ci --coverage --silent",

starsky/starsky/clientapp/src/components/atoms/detailview-info-make-model-aperture/detailview-info-make-model-aperture.tsx

@@ -2,10 +2,12 @@ import { memo } from "react";
 import { IFileIndexItem } from "../../../interfaces/IFileIndexItem";
 
 interface IDetailViewInfoMakeModelApertureProps {
-  fileIndexItem: IFileIndexItem;
+  fileIndexItem: Readonly<IFileIndexItem>;
 }
 
-function ShowISOIfExistComponent(fileIndexItemInside: IFileIndexItem) {
+function ShowISOIfExistComponent(
+  fileIndexItemInside: Readonly<IFileIndexItem>
+) {
   return (
     <>
       {fileIndexItemInside.isoSpeed !== 0 ? (

starsky/starsky/clientapp/src/components/atoms/file-hash-image/file-hash-image.spec.tsx

@@ -12,7 +12,7 @@ import * as PanAndZoomImage from "./pan-and-zoom-image";
 
 describe("FileHashImage", () => {
   it("renders", () => {
-    render(<FileHashImage isError={false} fileHash={""} />);
+    render(<FileHashImage fileHash={""} />);
   });
 
   beforeEach(() => {
@@ -53,7 +53,6 @@ describe("FileHashImage", () => {
     // need to await here
     const component = await render(
       <FileHashImage
-        isError={false}
         fileHash="hash"
         orientation={Orientation.Horizontal}
       />
@@ -96,7 +95,6 @@ describe("FileHashImage", () => {
 
     const component = render(
       <FileHashImage
-        isError={false}
         fileHash="hash"
         orientation={Orientation.Horizontal}
       />
@@ -128,7 +126,6 @@ describe("FileHashImage", () => {
 
     const component = render(
       <FileHashImage
-        isError={false}
         fileHash="hash"
         orientation={Orientation.Horizontal}
       />
@@ -168,7 +165,6 @@ describe("FileHashImage", () => {
 
     const component = render(
       <FileHashImage
-        isError={false}
         fileHash="hash"
         orientation={Orientation.Horizontal}
         id={"fallbackPath"}
@@ -216,7 +212,6 @@ describe("FileHashImage", () => {
     const onWheelCallbackSpy = jest.fn();
     const component = render(
       <FileHashImage
-        isError={false}
         fileHash="hash"
         id="/test.jpg"
         orientation={Orientation.Horizontal}
@@ -260,7 +255,6 @@ describe("FileHashImage", () => {
 
     const component = render(
       <FileHashImage
-        isError={false}
         fileHash="hash"
         id="/test.jpg"
         orientation={Orientation.Horizontal}
@@ -310,7 +304,6 @@ describe("FileHashImage", () => {
 
     const component = render(
       <FileHashImage
-        isError={false}
         fileHash="hash"
         id="/test.jpg"
         orientation={Orientation.Horizontal}

starsky/starsky/clientapp/src/components/atoms/file-hash-image/file-hash-image.tsx

@@ -7,11 +7,9 @@ import PanAndZoomImage from "./pan-and-zoom-image";
 
 export interface IFileHashImageProps {
   setError?: React.Dispatch<React.SetStateAction<boolean>>;
-  isError: boolean;
   setIsLoading?: React.Dispatch<React.SetStateAction<boolean>>;
   fileHash: string;
   orientation?: Orientation;
-  tags?: string;
   id?: string; // filepath to know when image is changed
   onWheelCallback?(z: number): void;
   onResetCallback?(): void;

starsky/starsky/clientapp/src/components/atoms/modal/modal.tsx

@@ -66,33 +66,31 @@ export default function Modal({
 
   if (modal.current) {
     return ReactDOM.createPortal(
-      <>
+      <div
+        onClick={(event) => ifModalOpenHandleExit(event, handleExit)}
+        data-test={dataTest}
+        className={`modal-bg ${
+          isOpen ? ` ${ModalOpenClassName} ` + className : ""
+        }`}
+      >
         <div
-          onClick={(event) => ifModalOpenHandleExit(event, handleExit)}
-          data-test={dataTest}
-          className={`modal-bg ${
-            isOpen ? ` ${ModalOpenClassName} ` + className : ""
-          }`}
+          className={`modal-content ${isOpen ? " modal-content--show" : ""}`}
         >
-          <div
-            className={`modal-content ${isOpen ? " modal-content--show" : ""}`}
-          >
-            <div className="modal-close-bar">
-              <button
-                className={`modal-exit-button ${
-                  isOpen ? " modal-exit-button--showing" : ""
-                }`}
-                ref={exitButton}
-                data-test="modal-exit-button"
-                onClick={handleExit}
-              >
-                {MessageCloseDialog}
-              </button>
-            </div>
-            {children}
+          <div className="modal-close-bar">
+            <button
+              className={`modal-exit-button ${
+                isOpen ? " modal-exit-button--showing" : ""
+              }`}
+              ref={exitButton}
+              data-test="modal-exit-button"
+              onClick={handleExit}
+            >
+              {MessageCloseDialog}
+            </button>
           </div>
+          {children}
         </div>
-      </>,
+      </div>,
       modal.current
     );
   }

starsky/starsky/clientapp/src/components/atoms/switch-button/switch-button.tsx

@@ -10,7 +10,7 @@ export interface ISwitchButtonProps {
   "data-test"?: string;
 }
 
-function SwitchButton(props: ISwitchButtonProps) {
+function SwitchButton(props: Readonly<ISwitchButtonProps>) {
   const [random, setRandom] = useState(0);
 
   useEffect(() => {

starsky/starsky/clientapp/src/components/molecules/search-pagination/search-pagination.tsx

@@ -93,14 +93,12 @@ const SearchPagination: React.FunctionComponent<IRelativeLink> = memo(
     }
 
     return (
-      <>
-        <div className="relativelink" data-test="search-pagination">
-          <h4 className="nextprev">
-            {prev()}
-            {next()}
-          </h4>
-        </div>
-      </>
+      <div className="relativelink" data-test="search-pagination">
+        <h4 className="nextprev">
+          {prev()}
+          {next()}
+        </h4>
+      </div>
     );
   }
 );