Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/202307 code smells 24 #1199

Merged
merged 10 commits into from
Jul 27, 2023
Merged

Feature/202307 code smells 24 #1199

merged 10 commits into from
Jul 27, 2023

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Jul 25, 2023

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1199 (508f022) into master (1ddae95) will increase coverage by 0.00%.
The diff coverage is 87.85%.

@@           Coverage Diff           @@
##           master    #1199   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files         547      547           
  Lines       18858    18881   +23     
  Branches     3119     3125    +6     
=======================================
+ Hits        17714    17736   +22     
  Misses        622      622           
- Partials      522      523    +1     
Flag Coverage Δ
all 93.93% <87.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...foundation.readmeta/ReadMetaHelpers/ReadMetaGpx.cs 87.75% <0.00%> (ø)
...c/components/atoms/button-styled/button-styled.tsx 100.00% <ø> (ø)
.../clientapp/src/hooks/realtime/websocket-service.ts 88.88% <ø> (ø)
...ts/organisms/menu-detail-view/menu-detail-view.tsx 74.61% <33.33%> (ø)
...ndation.database/Helpers/FileIndexCompareHelper.cs 89.92% <50.00%> (ø)
...tarsky.foundation.platform/Helpers/DateAssembly.cs 81.81% <50.00%> (-7.08%) ⬇️
starsky/starsky/Controllers/ImportController.cs 87.50% <50.00%> (ø)
starsky/starsky/Controllers/SearchController.cs 85.71% <50.00%> (-5.72%) ⬇️
...oundation.readmeta/ReadMetaHelpers/ReadMetaExif.cs 89.55% <75.00%> (ø)
...ature.health/HealthCheck/DiskStorageHealthCheck.cs 84.61% <100.00%> (+0.61%) ⬆️
... and 33 more

@qdraw qdraw merged commit 861ccfc into master Jul 27, 2023
@qdraw qdraw deleted the feature/202307_code_smells_24 branch July 27, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant