Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix conversion of datetime objects to grpc #697

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix: fix conversion of datetime objects to grpc #697

merged 1 commit into from
Jul 22, 2024

Conversation

joein
Copy link
Member

@joein joein commented Jul 19, 2024

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit ae7ca5d
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/669a7cd24a46c20008bd4913
😎 Deploy Preview https://deploy-preview-697--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein joein requested review from coszio, agourlay and generall July 19, 2024 15:27
Comment on lines +10 to +18
if PYDANTIC_V2:
import pydantic_core

to_jsonable_python = pydantic_core.to_jsonable_python
else:
from pydantic.json import ENCODERS_BY_TYPE

def to_jsonable_python(x: Any) -> Any:
return ENCODERS_BY_TYPE[type(x)](x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python monkeypatching magic

Copy link
Member

@agourlay agourlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this one 👍

@joein joein merged commit 03d1bc8 into dev Jul 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants