Fix length checks on inputs to ascii2hexstr() for WPS+NFC commands

The previously used checks were assuming incorrect direction for
hexdump/binary conversion and could have resulted in buffer write
overflow with invalid input. The used buffers were long enough to avoid
issues with valid input of maximum SSID/passphrase length, i.e., this
does not show up in normal CAPI operations.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>

p2p.c

@@ -2480,8 +2480,8 @@ static int nfc_wps_read_passwd(struct sigma_dut *dut,
 	run_system(dut, "killall wps-nfc.py");
 	run_system(dut, "killall p2p-nfc.py");
 
-	if ((ssid && strlen(ssid) >= 2 * sizeof(ssid_hex)) ||
-	    (passphrase && strlen(passphrase) >= 2 * sizeof(passphrase_hex))) {
+	if ((ssid && 2 * strlen(ssid) >= sizeof(ssid_hex)) ||
+	    (passphrase && 2 * strlen(passphrase) >= sizeof(passphrase_hex))) {
 		send_resp(dut, conn, SIGMA_ERROR,
 			  "ErrorCode,Too long SSID/passphrase");
 		return 0;

sta.c

@@ -8412,8 +8412,8 @@ static int cmd_sta_er_config(struct sigma_dut *dut, struct sigma_conn *conn,
 		return 0;
 	}
 
-	if (strlen(ssid) >= 2 * sizeof(ssid_hex) ||
-	    strlen(passphrase) >= 2 * sizeof(passphrase_hex)) {
+	if (2 * strlen(ssid) >= sizeof(ssid_hex) ||
+	    2 * strlen(passphrase) >= sizeof(passphrase_hex)) {
 		send_resp(dut, conn, SIGMA_ERROR,
 			  "ErrorCode,Too long SSID/passphrase");
 		return 0;