Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add failure threshold #53

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

rixtrayker
Copy link
Contributor

##Add failure threshold

this merge request adds a boolean flag shouldAlertDown depending on threshold value in case of 1
it should always be true

@what-the-diff
Copy link

what-the-diff bot commented Jun 16, 2023

PR Summary

  • Introduced new variables for better monitoring
    Added threshold, retries, and shouldAlertDown variables to enhance the Monitor class's functionality.
  • Refined address variable usage
    Updated the usage of the address variable in options for the request function call to increase code clarity (line 286).
  • Added updateRetries() method
    Implemented a new method, updateRetries(), to manage the value of retries depending on whether the threshold has been reached or not (lines 420-431).

@qawemlilo
Copy link
Owner

@rixtrayker I think this is a great idea. Will merge and do some tests.

@qawemlilo qawemlilo merged commit 372c55b into qawemlilo:master Jun 19, 2023
@qawemlilo
Copy link
Owner

Hey @rixtrayker , I have started working on integrating your pull requests. Sorry for the delays, I will update you when I publish a new release.

@qawemlilo
Copy link
Owner

Hey @rixtrayker - please have a look at the v0.8.1 release candidate.

I have made a changes to your pull request and added a new event for retries.

I changed the default value of shouldAlertDown to true since this is the current default behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants