Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
grid.alpha
parameterrAB = rA * rB
, where rotations are done in A, B order.These changes were originally added in #442. The main change in that PR has to wait for other changes before we can continue with it, so I'm making separate PRs for the changes that we can merge now.
Progress of the PR
Minimal example of the bug fix or new feature
See the new example on combining rotations to see all the changes in this PR in action: https://orix--445.org.readthedocs.build/en/445/examples/rotations/combine_rotations.html
For reviewers
__init__.py
.section in
CHANGELOG.rst
.__credits__
inorix/__init__.py
and in.zenodo.json
.