-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a reader for NWC SAF GEO HRW data #3070
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3070 +/- ##
========================================
Coverage 96.13% 96.13%
========================================
Files 383 385 +2
Lines 55688 55909 +221
========================================
+ Hits 53534 53750 +216
- Misses 2154 2159 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I reduced the number of data rows that were written to the test data. With the original |
I'll have a look at adding a kwarg to merge the different channel observations, so the user could do something like scn = Scene(reader="nwcsaf-geo", filenames=filenames, reader_kwargs={"merge_channels": True})
scn.load(["wind_speed", "wind_from_direction"]) instead of loading each of the channels ( |
Also some documentation added. |
Pull Request Test Coverage Report for Build 13564327912Details
💛 - Coveralls |
This PR adds a reader for the High Resolution Winds data from NWC SAF GEO.
The data structure is very complex, and due to the unsupported compound data type can't be opened with
xr.open_dataset()
. Because there are 259 datasets, I've made the dataset definitions dynamic instead of putting them into the reader YAML. The code is in a separate file because the internal structure is completely different to the other NWC SAF GEO products (see the linked issue).By default the file handler reads the datasets separately for each imaging channel. That is, the datasets are named
wind_vis06_air_pressure
,wind_hrvis_wind_speed
, and so on. The prefix is the name of the channel within the files.The user can also supply
reader_kwargs={"merge_channels": True}
to collect all the data together. In this case the datasets are named without the prefix, such asair_pressure
,wind_speed
, etc.