Fix assumption that arrays have 2+ dimensions in CF writer #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraspaud
approved these changes
Apr 19, 2023
|
3 tests failing now... |
|
The failing tests were because of the netCDF compression settings not working with the latest XArray version. |
Codecov Report
@@ Coverage Diff @@
## main #2451 +/- ##
==========================================
- Coverage 94.81% 94.81% -0.01%
==========================================
Files 339 339
Lines 49391 49343 -48
==========================================
- Hits 46832 46784 -48
Misses 2559 2559
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I arranged the imports in |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CF writer currently has an assumption that all arrays have both x and y coordinates. This might not be intentional, as the only place this is enforced is in a private method where coordinate units are check when trying to determine whether the data are projected or not.
This had come up in https://github.com/foua-pps/level1c4pps/ which uses Satpy to convert data to NWC SAF PPS compatible format.
The test I added is very simple, and without the
try/exceptI added in this PR it'd fail withKeyError: 'x'.Ping also to @ninahakansson