Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MET09 IODC service mode #2278

Merged
merged 5 commits into from
Dec 19, 2022

Conversation

strandgren
Copy link
Collaborator

@strandgren strandgren commented Nov 16, 2022

This PR adds a new service mode of SEVIRI, which is the IODC mission at 45.5 degrees East. This is the position of the MET09 satellite which took over the operational IODC service in summer 2022.

Furthermore, this PR updates the sub-satellite longitude of the standardized area definitions of the MSG SEVIRI IODC mission. This is needed in order to be compliant with current/operational data until issue #2238 has been resolved.

Copy link
Collaborator

@sjoro sjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu
Copy link
Member

pnuu commented Nov 21, 2022

The tests need some adjustments in satpy.tests.reader_tests.test_seviri_l2_bufr.TestSeviriL2BufrReader.test_data_with_area_definition:

  • different lon_0
  • minor difference in extents (rounding?)

@strandgren
Copy link
Collaborator Author

ups, given how minor the change was I forgot that the tests were affected.. Have fixed this now. The differences were indeed rounding errors and have also been fixed. Thanks for reviewing!

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #2278 (5f13921) into main (f9c2070) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2278      +/-   ##
==========================================
+ Coverage   94.32%   94.58%   +0.26%     
==========================================
  Files         308      314       +6     
  Lines       46168    47518    +1350     
==========================================
+ Hits        43546    44943    +1397     
+ Misses       2622     2575      -47     
Flag Coverage Δ
behaviourtests 4.50% <0.00%> (-0.11%) ⬇️
unittests 95.21% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/eum_base.py 89.79% <ø> (ø)
satpy/tests/reader_tests/test_eum_base.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_seviri_l2_bufr.py 100.00% <100.00%> (ø)
satpy/composites/ahi.py 0.00% <0.00%> (-100.00%) ⬇️
satpy/readers/netcdf_utils.py 98.32% <0.00%> (-1.68%) ⬇️
satpy/tests/test_resample.py 88.90% <0.00%> (-0.37%) ⬇️
satpy/readers/yaml_reader.py 97.49% <0.00%> (-0.01%) ⬇️
satpy/tests/test_utils.py 100.00% <0.00%> (ø)
satpy/composites/spectral.py 100.00% <0.00%> (ø)
satpy/readers/seviri_base.py 100.00% <0.00%> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

coveralls commented Nov 21, 2022

Coverage Status

Coverage increased (+0.3%) to 95.161% when pulling 5f13921 on strandgren:add_met9_iodc_service_mode into f9c2070 on pytroll:main.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Copy link
Collaborator

@sjoro sjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small test should be added to eum_base to cover the new service location.

@sfinkens sfinkens merged commit 0946737 into pytroll:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing SEVIRI service mode for new IODC sub-satellite longitude of MET09
6 participants