-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MET09 IODC service mode #2278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The tests need some adjustments in
|
ups, given how minor the change was I forgot that the tests were affected.. Have fixed this now. The differences were indeed rounding errors and have also been fixed. Thanks for reviewing! |
Codecov Report
@@ Coverage Diff @@
## main #2278 +/- ##
==========================================
+ Coverage 94.32% 94.58% +0.26%
==========================================
Files 308 314 +6
Lines 46168 47518 +1350
==========================================
+ Hits 43546 44943 +1397
+ Misses 2622 2575 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small test should be added to eum_base
to cover the new service location.
This PR adds a new service mode of SEVIRI, which is the IODC mission at 45.5 degrees East. This is the position of the MET09 satellite which took over the operational IODC service in summer 2022.
Furthermore, this PR updates the sub-satellite longitude of the standardized area definitions of the MSG SEVIRI IODC mission. This is needed in order to be compliant with current/operational data until issue #2238 has been resolved.