Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read goes-r data from https aws, gcp or azure (it uses netcdf4) #1423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhbravo
Copy link
Contributor

@jhbravo jhbravo commented Nov 5, 2020

Hello, @djhoese
As I wrote in the slack, I just uploaded the methods to read data from https, it may not be the best method but it has worked for me
this uses netcdf4, and is adapted of this ipynb:
https://github.com/HamedAlemo/visualize-goes16/blob/master/visualize_GOES16_from_AWS.ipynb

  • Closes #xxxx
  • Tests added
  • Passes flake8 satpy
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1423 into master will decrease coverage by 0.01%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
- Coverage   90.58%   90.57%   -0.02%     
==========================================
  Files         236      236              
  Lines       33797    33806       +9     
==========================================
+ Hits        30615    30619       +4     
- Misses       3182     3187       +5     
Impacted Files Coverage Δ
satpy/readers/abi_base.py 90.20% <54.54%> (-2.33%) ⬇️
satpy/scene.py 90.44% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ccddbf...d96ae87. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 90.573% when pulling d96ae87 on jhbravo:read_https_1 into 9ccddbf on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 90.573% when pulling d96ae87 on jhbravo:read_https_1 into 9ccddbf on pytroll:master.

@djhoese
Copy link
Member

djhoese commented Nov 5, 2020

Thanks for making these PRs. Nice to see some alternative solutions. We've done some experimenting with other tools. Some of this work isn't on github yet but we've had some discussions in #1169 and #1321 and #1349. We're hoping to come up with a solution that works for most readers (at least the ones that use xarray directly) without having to modify individual readers/file handlers. We will definitely use what you've done as inspiration. If we can't come up with a generic solution then we will likely merge what you've done here. For now, if it is OK with you, I'd like to wait and see what generic solution we can come up with. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants