Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EWA pyproj Proj usage to Transformer #648

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 17, 2025

The pyproj Proj object is deprecated and is not as accurate/explicit as the Transformer interface. I did some of these changes in my #645 branch, but decided that these changes should be their own PR. Unfortunately this also meant that I changed the low-level interfaces of ll2cr to accept a source CRS and a target CRS instead of just the target projection information.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Fully documented

@djhoese djhoese added enhancement backwards-incompatibility Causes backwards incompatibility or introduces a deprecation labels Feb 17, 2025
@djhoese djhoese self-assigned this Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.98%. Comparing base (eb37fa0) to head (98f20a7).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   93.97%   93.98%           
=======================================
  Files          86       86           
  Lines       13536    13543    +7     
=======================================
+ Hits        12721    12728    +7     
  Misses        815      815           
Flag Coverage Δ
unittests 93.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Feb 17, 2025

Coverage Status

coverage: 93.677% (+0.003%) from 93.674%
when pulling 98f20a7 on djhoese:udpate-ewa-pyproj-transformer
into 1f974b5 on pytroll:main.

@djhoese
Copy link
Member Author

djhoese commented Feb 18, 2025

Merging this to get the versioneer fixes and also I'm the primary EWA user anyway so...it should be fine and if not I'll fix it.

@djhoese djhoese merged commit 873a511 into pytroll:main Feb 18, 2025
28 checks passed
@djhoese djhoese deleted the udpate-ewa-pyproj-transformer branch February 18, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants