-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs and use real data in the plotting docs #251
Merged
djhoese
merged 17 commits into
pytroll:master
from
adybbroe:fix-documentation-error-cartopy-plotting
May 12, 2020
Merged
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2b7c526
Fix bugs and use real data in the doc pages but hide code needed for …
551c25c
Skip doc testing the resampling, it is done already earlier
b0fe478
Make Travis happy
c4c6958
Merge branch 'master' into fix-documentation-error-cartopy-plotting
2ad5904
Try make Travis happy with the doc tests
b5e4597
Add back code example so it is visible in the doc pages
b1240bb
Divide plottting example pages into three source files
7e1e1a0
Improve and condense the plot examples pages
7c26f10
Rename main plot rst file back to original naming
c1d0cad
Rewrite plotting docs to render correctly
djhoese f3db969
Remove extra whitespace
djhoese 06d7b40
Skip more sphinx doctests when matplotlib isn't installed
djhoese 1677410
Fix indentation of plot_projections example
djhoese 2c52125
Debugging weird travis Windows reading behavior
djhoese aebcfcd
Fix symbolic link reading in travis windows
djhoese 0f6ba62
Try using functions that actually exist
djhoese 9e70cd5
Skip doctest downloading cartopy shapefiles
djhoese File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this area load just overwriting the area_def created in the lines above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, right. But the stuff above is hidden, and does not show up on RTD. Therefore the additional line for RTD. The area is not defined and on Travis we don't have access to
areas.yaml
and certainly not in the home dir.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, pyresample doesn't have a builtin areas 🤦♂️ Got it.