Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tarfile support #82

Merged
merged 3 commits into from
Jan 19, 2021
Merged

add tarfile support #82

merged 3 commits into from
Jan 19, 2021

Conversation

carloshorn
Copy link

This PR closes #4 by adding a TarFileSystem class to pygac-fdr and using it with the FSFile feature of satpy.

@ghost
Copy link

ghost commented Dec 15, 2020

Congratulations 🎉. DeepCode analyzed your code in 5.83 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@carloshorn
Copy link
Author

@sfinkens, I have set this PR as draft, because it depends on the successful merge of pytroll/pygac#92.

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@carloshorn carloshorn marked this pull request as ready for review January 14, 2021 14:59
@carloshorn
Copy link
Author

Should be ready to merge, because the dependent PR on pygac has been merged pytroll/pygac#92!

@mraspaud mraspaud merged commit ae76af3 into pytroll:master Jan 19, 2021
@mraspaud mraspaud added the enhancement New feature or request label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow tarball as input for pygac-fdr-run
3 participants