Redo torchscript example #7889
Redo torchscript example #7889
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7889
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New FailuresAs of commit 8057bc7 with merge base 6472a5c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| # Below we now show how to combine image transformations and a model forward | ||
| # pass, while using ``torch.jit.script`` to obtain a single scripted module. |
There was a problem hiding this comment.
This was a quick re-write and I didn't give this the same attention as the other examples. After 1+ week of writing docs I don't have much mental space left to dedicate to this. In particular, I didn't change anything to the text below. So if you have comments about it, and since everything below is pre-existing, I suggest to follow-up in other PRs if needed.
| @@ -172,6 +172,7 @@ | |||
| # Re-using the transforms and definitions from above. | |||
| out_img, out_target = transforms(img, target) | |||
|
|
|||
| # sphinx_gallery_thumbnail_number = 4 | |||
There was a problem hiding this comment.
LGTM, thanks Nicolas! Just noting here that placing this into the "transforms" section might not be the best fit. While containing some transforms, the latter part of the tutorial mainly deals with the whole pipeline and the predictions. Since the only use of v2 is inside the warning, I would also be ok with leaving this gallery in the "others" section. Up to you.
OK, I'll put it back where it was and keep its original name to preserve the html links. I'll keep the new title. |
Summary: (Note: this ignores all push blocking failures!) Reviewed By: matteobettini Differential Revision: D48900398 fbshipit-source-id: 66331de8d66c93aab1e91b154a5ce29371299b9b
No description provided.