Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable v1 vs. v2 consistency in refactored tests #7882

Merged
merged 12 commits into from
Aug 28, 2023
Merged

Enable v1 vs. v2 consistency in refactored tests #7882

merged 12 commits into from
Aug 28, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Aug 25, 2023 •
edited by pytorch-bot bot
Loading

@pmeier pmeier requested a review from NicolasHug August 25, 2023 09:51
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7882

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures

As of commit ab4d41e with merge base 47cd5ea (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:53 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:53 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:53 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:53 — with GitHub Actions Inactive
pmeier
pmeier commented Aug 25, 2023
View reviewed changes
test/test_transforms_v2_consistency.py
@@ -83,35 +82,6 @@ def __init__(
supports_pil=False,
make_images_kwargs=dict(DEFAULT_MAKE_IMAGES_KWARGS, dtypes=[torch.float]),
),
ConsistencyConfig(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these configs are now obsolete. Going forwards, whenever we port a new test to test_*_refactored.py, we can also remove the configs here.

test/test_transforms_v2_consistency.py
@@ -514,23 +395,6 @@ def __init__(
]


def test_automatic_coverage():
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was useful in the beginning, to ensure we are not missing something. But now that we start to remove configs here, we need to remove this check as well.

@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:58 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 09:58 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:50 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:50 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:50 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:50 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:51 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:51 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:51 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:51 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:51 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:51 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:51 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:51 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:51 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:52 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 13:54 — with GitHub Actions Inactive
@pmeier pmeier temporarily deployed to pytorchbot-env August 25, 2023 14:05 — with GitHub Actions Inactive
@pmeier pmeier merged commit fae5321 into pytorch:main Aug 28, 2023
@pmeier pmeier deleted the v2-consistency branch August 28, 2023 07:48
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier mentioned this pull request Aug 28, 2023
Merged
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
@NicolasHug @facebook-github-bot
[fbsync] Enable v1 vs. v2 consistency in refactored tests (#7882)
afecea2 
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: matteobettini

Differential Revision: D48900410

fbshipit-source-id: 8491c6a4ef8fbdd09c411b65f9ff3fc45283d2b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: tests module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot