Stricter SanitizeBoundingBoxes labels_getter heuristic #7880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7880
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 1 Unrelated FailureAs of commit 9d11700 with merge base 054432d ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
commented
Aug 24, 2023
| v2.SanitizeBoundingBoxes(), | ||
| v2.RandomResizedCrop(size=(224, 224), antialias=True), | ||
| v2.RandomPhotometricDistort(p=1), | ||
| v2.RandomHorizontalFlip(p=1), |
There was a problem hiding this comment.
I was actually mis-using SanitizeBoundingBoxes() as I wasn't passing a label, so I should have set labels_getter to None (see non-regression test below). I decided to just remove SanitizeBoundingBoxes here because that would require making the input a dict, also forcing to change the narrative below. It's OK, SanitizeBoundingBoxes will be clearly used and mentioned in the e2e example that I'm working on now.
pmeier
approved these changes
Aug 24, 2023
|
CI is toasted, some linux unit tests jobs are passing so I'll merge, thanks for the quick review! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
Summary: (Note: this ignores all push blocking failures!) Reviewed By: matteobettini Differential Revision: D48900400 fbshipit-source-id: 022f3867c943f6938ec9ac9b43b13eacf53e14d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7878
cc @vfdev-5