-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed setup.py when missing libjpeg #7840
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,9 +82,10 @@ Torchvision currently supports the following image backends: | |
- [libjpeg](http://ijg.org/) - can be installed via conda `conda install jpeg` or any of the package managers for | ||
debian-based and RHEL-based Linux distributions. [libjpeg-turbo](https://libjpeg-turbo.org/) can be used as well. | ||
|
||
**Notes:** `libpng` and `libjpeg` must be available at compilation time in order to be available. Make sure that it is | ||
available on the standard library locations, otherwise, add the include and library paths in the environment variables | ||
`TORCHVISION_INCLUDE` and `TORCHVISION_LIBRARY`, respectively. | ||
**Notes:** `libpng` and `libjpeg` are optional dependencies. If any of them is available on the system, | ||
torchvision will provide encoding/decoding image functionalities from `torchvision.io.image`. | ||
When building torchvision from source, `libpng` and `libjpeg` can be found on the standard library locations. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should say that. It depends on whether the user installed them. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you detail what is incorrect here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't know whether those libraries can be found on the standard library locations. If users didn't install them, then they won't be found there. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, I think I need to rephrase the sentence I wrote: " |
||
Otherwise, please use `TORCHVISION_INCLUDE` and `TORCHVISION_LIBRARY` environment variables to set up include and library paths. | ||
|
||
## Video Backend | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to clarify that libjpeg and libpng are optional, but I don't think we need to remove that sentence:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I do not understand what you ask. Libs are optional and this sentence "libpng and libjpeg must be available at compilation time in order to be available." does not make sense (without speaking that it is unclear what it is exactly "in order be available")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the sentence means
We don't need to remove it