-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix elastic error #7838
Merged
Merged
fix elastic error #7838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip, lgtm!
Merged
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
Summary: Co-authored-by: vfdev <vfdev.5@gmail.com> Reviewed By: matteobettini Differential Revision: D48642275 fbshipit-source-id: 7bc2e758f5efb3631c5460932d1a9e2fde96f36b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally removed an error in #7977 (thanks @vfdev-5 for spotting).
Before:
vision/torchvision/transforms/v2/functional/_geometry.py
Lines 1784 to 1794 in 84db2ac
After:
vision/torchvision/transforms/v2/functional/_geometry.py
Lines 1732 to 1744 in c1592f9
We could put the error back into the functional, but I feel we should raise proper error messages on the kernels as well. Although this means a little code duplication for us, as a user I would be surprised of the functional raises a proper error, but the kernel doesn't. In this case, the duplication is minimal, since all kernels beside the bounding boxes one, call the image kernel.
I've also added tests for elastic.
cc @vfdev-5