-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow dispatch to PIL image subclasses #7835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7835
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New FailuresAs of commit e3db48a with merge base c1592f9 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vfdev-5
reviewed
Aug 16, 2023
NicolasHug
reviewed
Aug 16, 2023
NicolasHug
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if green, thanks Philip
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
Reviewed By: matteobettini Differential Revision: D48642256 fbshipit-source-id: 8595836f1e5382eccede49c77247651faee23398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug that was spotted by @vfdev-5:
This PR removes the restriction that we only walk up the MRO for
datapoints.Datapoint
and thus enabling an "isinstance
" check forPIL.Image.Image
.That also means that we can now also register kernels for subclasses of
PIL.Image.Image
ortorch.Tensor
. However, since we don't plan on doing that and users are not allowed to do sovision/torchvision/transforms/v2/functional/_utils.py
Lines 86 to 90 in 498b9c8
this has no other side-effect. It actually simplifies the code.
cc @vfdev-5