Remove wrap_like class method and add datapoints.wrap() function #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
approved these changes
Aug 15, 2023
| @@ -12,3 +12,25 @@ | |||
| import warnings | |||
|
|
|||
| warnings.warn(_BETA_TRANSFORMS_WARNING) | |||
|
|
|||
There was a problem hiding this comment.
Not going to block over this, but I would prefer keeping logic out of __init__.py.
| @@ -12,3 +12,25 @@ | |||
| import warnings | |||
|
|
|||
| warnings.warn(_BETA_TRANSFORMS_WARNING) | |||
|
|
|||
|
|
|||
| def wrap(wrappee, *, like, **kwargs): | |||
There was a problem hiding this comment.
Suggested change
| def wrap(wrappee, *, like, **kwargs): | |
| D = TypeVar("D", bounds=Datapoint) | |
| def wrap(wrappee: torch.Tensor, *, like: D, **kwargs: Any) -> D: |
There was a problem hiding this comment.
I had merged the suggestion and fixed the imports but it created more problems in the BBox._wrap, so I'm getting rid of it. Mypy is green anyway.
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
…tion (#7832) Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de> Reviewed By: matteobettini Differential Revision: D48642267 fbshipit-source-id: 43331507612c8980dd275aaaa40d38801a3c95c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @vfdev-5