Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make PIL kernels private #7831

Merged
merged 11 commits into from
Aug 16, 2023
Merged

make PIL kernels private #7831

merged 11 commits into from
Aug 16, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Aug 15, 2023

Closes #7808.

cc @vfdev-5

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 15, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7831

Note: Links to docs will display an error until the docs builds have been completed.

❌ 28 New Failures

As of commit a4219d8 with merge base cdbbd66 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green but we need to rename to_image_tensor and ToImageTensor as well

@pmeier
Copy link
Collaborator Author

pmeier commented Aug 16, 2023

As discussed offline, we are also renaming a few things here:

  • ToImageTensor -> ToImage. This also clears up the issue that ToImageTensor returns a datapoints.Image although the name suggests otherwise:

  • ToImagePIL -> ToPILImage. This is what it was named in v1 and we currently only have it as alias:

    # We changed the name to align them with the new naming scheme. Still, `ToPILImage` is
    # prevalent and well understood. Thus, we just alias it without deprecating the old name.
    ToPILImage = ToImagePIL

    Since the naming scheme is no longer valid, we can also remove the new transform and reinstate the old one.

All arguments here apply to the functional counterparts as well.

@pmeier pmeier requested a review from vfdev-5 August 16, 2023 11:33
@pmeier pmeier merged commit ca012d3 into pytorch:main Aug 16, 2023
@pmeier pmeier deleted the pil-private branch August 16, 2023 14:09
@pmeier pmeier mentioned this pull request Aug 16, 2023
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
Reviewed By: matteobettini

Differential Revision: D48642311

fbshipit-source-id: 3a019c12988c1fb34bbec320d1fda7dd8c8e7b44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make PIL kernels private?
3 participants