Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ToPureTensor transform #7823

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Add ToPureTensor transform #7823

merged 6 commits into from
Aug 17, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Aug 10, 2023 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7823

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 1 Unrelated Failure

As of commit d4bd9d9 with merge base 3554d80 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug requested review from vfdev-5 and pmeier August 10, 2023 10:37
pmeier
pmeier approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline. Nothing major so stamping to unblock.

NicolasHug
NicolasHug commented Aug 10, 2023
View reviewed changes
torchvision/transforms/v2/_type_conversion.py
_transformed_types = (datapoints.Image, datapoints.Video, datapoints.Mask, datapoints.BoundingBoxes)

def _transform(self, inpt: Any, params: Dict[str, Any]) -> torch.Tensor:
return inpt.as_subclass(torch.Tensor)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need / want a functional for this. The functional would just wrap .as_subclass(torch.Tensor) which is already public and users should just use that

@NicolasHug @pmeier
Update torchvision/transforms/v2/_type_conversion.py
9c001f0 
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
@NicolasHug NicolasHug merged commit 69220e0 into pytorch:main Aug 17, 2023
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
@NicolasHug @facebook-github-bot
[fbsync] Add ToPureTensor transform (#7823)
8e1134b 
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de>

Reviewed By: matteobettini

Differential Revision: D48642260

fbshipit-source-id: c8f287816cc22508274c492703b6938fade169ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 left review comments

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasHug @vfdev-5 @pmeier @facebook-github-bot