Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove custom types defintions from datapoints module #7814

Merged
merged 2 commits into from
Aug 9, 2023
Merged

remove custom types defintions from datapoints module #7814

merged 2 commits into from
Aug 9, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Aug 9, 2023 •
edited by pytorch-bot bot
Loading

This does two things:

  1. Move the _FillType and _FillTypeJIT from torchvision.datapoints to torchvision.transforms.v2.functional. We only had them in the datapoints module before, since we needed them to annotate the methods on the classes due to our convoluted dispatch mechanism. With the new one in place, there is no need to keep it there anymore.
  2. Remove the _InputType, _InputTypeJIT, ..., types, since they added very little value. After move passthrough for unknown types from dispatchers to transforms #7804, they will also be wrong, since we let _transform handle the unsupported types automatically, rather than hardcoding it.

cc @vfdev-5

@pmeier pmeier requested a review from NicolasHug August 9, 2023 09:34
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7814

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures

As of commit 5894e31:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier
Copy link
Collaborator Author

pmeier commented Aug 9, 2023

mypy job is green: https://github.com/pytorch/vision/actions/runs/5807368371/job/15742054757?pr=7814

@pmeier pmeier merged commit 641fdd9 into pytorch:main Aug 9, 2023
@pmeier pmeier deleted the cleanup-helper-types branch August 10, 2023 09:09
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
@NicolasHug @facebook-github-bot
[fbsync] remove custom types defintions from datapoints module (#7814)
fcf70d3 
Reviewed By: matteobettini

Differential Revision: D48642264

fbshipit-source-id: 1d3d9cee74ad998650145403b7d28c50ac118b3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot