-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default pytest traceback from native to short #7810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections here. IIRC, we just copied the configuration from core and they had --tb=native
, because it supposedly (I've never checked) better for tracebacks that start in the C++ layer.
Ah OK, good to keep in mind. Considering we very rarely do C++ stuff I guess it's still fine. LMK if you notice any undersirable change on your setup |
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: matteobettini Differential Revision: D48642269 fbshipit-source-id: 1eff194c0283b1aad0994bf9e58691ffc7d1b4ea
IDK why but
short
looks much better on my terminal (and it's the same size)native:

short:
