Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default pytest traceback from native to short #7810

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

NicolasHug
Copy link
Member

IDK why but short looks much better on my terminal (and it's the same size)

native:
native

short:
short

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 8, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7810

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures

As of commit fe6cb92:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections here. IIRC, we just copied the configuration from core and they had --tb=native, because it supposedly (I've never checked) better for tracebacks that start in the C++ layer.

@NicolasHug
Copy link
Member Author

NicolasHug commented Aug 9, 2023

Ah OK, good to keep in mind. Considering we very rarely do C++ stuff I guess it's still fine. LMK if you notice any undersirable change on your setup
CC @vfdev-5 as well

@NicolasHug NicolasHug merged commit 2ab937a into pytorch:main Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug added code quality other if you have no clue or if you will manually handle the PR in the release notes labels Aug 9, 2023
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
Reviewed By: matteobettini

Differential Revision: D48642269

fbshipit-source-id: 1eff194c0283b1aad0994bf9e58691ffc7d1b4ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed code quality other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants