Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cutmix -> CutMix #7784

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Cutmix -> CutMix #7784

merged 3 commits into from
Aug 1, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Aug 1, 2023 •
edited by pytorch-bot bot
Loading

@pmeier @vfdev-5: discuss

Follow up to #7772 (comment)

(Note that timm names them Cutmix and Mixup)

cc @vfdev-5

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 1, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7784

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 New Failures

As of commit b8d0030:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 1, 2023

@NicolasHug My comment was only about the documentation, class names can be Cutmix and Mixup

pmeier
pmeier approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nicolas

torchvision/prototype/transforms/_augment.py
@@ -14,7 +14,7 @@
from torchvision.transforms.v2.utils import has_any, is_simple_tensor, query_size


class _BaseMixupCutmix(_RandomApplyTransform):
class _BaseMixUpCutMix(_RandomApplyTransform):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we delete them from prototype now that we have a proper implementation in v2? If you do, note that there are tests for this in test/test_prototype_transforms.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in another PR

@NicolasHug NicolasHug merged commit 3e4e353 into pytorch:main Aug 1, 2023
This was referenced Aug 1, 2023
Merged
Merged
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
@NicolasHug @facebook-github-bot
[fbsync] Cutmix -> CutMix (#7784)
6fbb501 
Reviewed By: matteobettini

Differential Revision: D48642274

fbshipit-source-id: 2bf95841d5cc45d77e8def3e427d3386ae8e1148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasHug @vfdev-5 @pmeier @facebook-github-bot