-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming: BoundingBox
-> BoundingBoxes
#7778
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7778
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 829e50e: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for 1. and 3. For 2. I prefer keeping it in the long version, i.e. BoundingBoxes
and BoundingBoxFormat
. However, I'm not going to block over that. @vfdev-5 opinion?
Edit: Sorry this is confusing. With 1., 2. and 3. I mean the three bullet points in the top comment. To re-iterate, I prefer BoundingBoxes
and BoundingBoxFormat
Lint failures are real. You need to run the auto-formatters, since a few lines are shrinking when going to |
yes and rename the kernels as well.. just looking for consensus first |
@@ -349,15 +349,15 @@ def test__transform_bounding_box_clamping(self, mocker): | |||
), | |||
) | |||
|
|||
bounding_box = make_bounding_box( | |||
bounding_boxes = make_bounding_box( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This call is a bit awkward now.
I didn't want to change make_bouding_box
into make_bounding_boxes
because make_bouding_boxes
already exists.
I'm hoping we'll be able to get rid of the current make_bouding_boxes
util soon anyway? CC @pmeier
BoundingBox
-> BBoxes
BoundingBox
-> BoundingBoxes
Tests were passing in previous commit and docs are now passing, merging |
Reviewed By: matteobettini Differential Revision: D48642250 fbshipit-source-id: 4b73395c906899de4c0ee049dc26436bb435ce1b
EDIT: actually all this does is rename
BoudingBox
intoBoundingBoxes
: the class, and its occurrences in transforms likeSanitizeBoudingBoxES
.BoudingBoxFormat
is left unchanged. Also renamed the correspdoning kernels to take an extraes
.This PR renames:
BoundingBoxFormat
intoBBoxFormat
BoundingBox
class (and its use in methods likeSanitizedBoundingBox
intoBBoxes
:A few thing to note:
BBoxesFormat
but meh.BoundingBoxesFormat
is pretty long IMHO.)BoundingBox
intoBBox
. Personally, I thinkBBox
is just as expressive and clear, for half of the length needed (andBoundingBoxesFormat.XYXY
orSanitizeBoundingBoxes
are kinda long), so I think its a good thing. I won't die on that hill though.s
to theBoundingBox
class - we had agreed on that already. The rest, I'll yield to whatever you prefer.CC @vfdev-5 @pmeier
cc @vfdev-5