Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the confusing example of gt_pred_pairs_of_highest_quality #7730

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Fix the confusing example of gt_pred_pairs_of_highest_quality #7730

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0a15c5
Update _utils.py
fansuregrin Jul 10, 2023
79a3691
Fix the confusing example of `gt_pred_pairs_of_highest_quality`
fansuregrin Jul 10, 2023
08503ad
Fix the confusing example of gt_pred_pairs_of_highest_quality
fansuregrin Jul 10, 2023
f3a6799
Update torchvision/models/detection/_utils.py
NicolasHug Jul 11, 2023
f45924a
Merge branch 'main' into patch-1
NicolasHug Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions torchvision/models/detection/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,17 +408,9 @@ def set_low_quality_matches_(self, matches: Tensor, all_matches: Tensor, match_q
# Find the highest quality match available, even if it is low, including ties
gt_pred_pairs_of_highest_quality = torch.where(match_quality_matrix == highest_quality_foreach_gt[:, None])
# Example gt_pred_pairs_of_highest_quality:
# tensor([[ 0, 39796],
# [ 1, 32055],
# [ 1, 32070],
# [ 2, 39190],
# [ 2, 40255],
# [ 3, 40390],
# [ 3, 41455],
# [ 4, 45470],
# [ 5, 45325],
# [ 5, 46390]])
# Each row is a (gt index, prediction index)
# (tensor([0, 1, 1, 2, 2, 3, 3, 4, 5, 5]),
# tensor([39796, 32055, 32070, 39190, 40255, 40390, 41455, 45470, 45325, 46390]))
# Each element in the first tensor is a gt index, and each element in second tensor is a prediction index
# Note how gt items 1, 2, 3, and 5 each have two ties

pred_inds_to_update = gt_pred_pairs_of_highest_quality[1]
Expand Down