make datapoints deepcopyable #7701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Jun 27, 2023
NicolasHug
reviewed
Jun 27, 2023
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
Reviewed By: vmoens Differential Revision: D47186567 fbshipit-source-id: a7d313c8ef1a4fd5d41f8bff8057c0bff666b81a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6478.
This PR does three things:
test_prototype_datapoints.pyintotest_datapoints.py. The only prototype datapoints are the labels. However, all tests in the file were independent of labels, since they were just used as example. I refactored them to use images instead.Tensor.detachto the list of ops that will not unwrap a datapoint, e.g.Image.detachwill give you back anImagerather than aTensor. This is not a requirement for the overall goal of this PR, but something that I found along the way.__deepcopy__method to the datapoints according to 2. in datapoints cannot be deepcopied #6478.