Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build using VS2022 #7694

Merged
merged 2 commits into from
Jun 22, 2023
Merged

CMake build using VS2022 #7694

merged 2 commits into from
Jun 22, 2023

Conversation

Blackhex
Copy link
Contributor

@Blackhex Blackhex commented Jun 22, 2023

Builds "cmake" job using Visual Studio 2022 Build Tools.
Fixes: #7682

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 22, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7694

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0fdbd4b:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Blackhex Blackhex force-pushed the vs2022-build branch 2 times, most recently from 14da8ef to b11a1e0 Compare June 22, 2023 13:54
@atalman atalman marked this pull request as ready for review June 22, 2023 14:33
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman atalman changed the title [WIP] CMake build using VS2022 CMake build using VS2022 Jun 22, 2023
@atalman atalman merged commit 463cdea into pytorch:main Jun 22, 2023
@github-actions
Copy link

Hey @atalman!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jul 3, 2023
Summary: Co-authored-by: Andrey Talman <atalman@fb.com>

Reviewed By: vmoens

Differential Revision: D47186588

fbshipit-source-id: 988acd6df7f2bf4f8c9ef41ec6bd9e42b94a545a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake workflows on Windows are broken
3 participants