Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test RNG #7693

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Fix test RNG #7693

merged 2 commits into from
Jun 22, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Jun 22, 2023 •
edited by pytorch-bot bot
Loading

These tests are flaky and have been causing spurious issues.

cc @pmeier

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 22, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7693

Note: Links to docs will display an error until the docs builds have been completed.

❌ 33 New Failures

As of commit 03bfee7:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vfdev-5
vfdev-5 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @NicolasHug !

@NicolasHug NicolasHug merged commit f81d68a into pytorch:main Jun 22, 2023
@NicolasHug NicolasHug added module: tests other if you have no clue or if you will manually handle the PR in the release notes labels Jun 22, 2023
facebook-github-bot pushed a commit that referenced this pull request Jul 3, 2023
@NicolasHug @facebook-github-bot
[fbsync] Fix test RNG (#7693)
bb28e03 
Reviewed By: vmoens

Differential Revision: D47186574

fbshipit-source-id: 2cb1874ab5df6425f054091b867f9ea8e58a4614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
cla signed module: tests other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @vfdev-5 @facebook-github-bot