-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add objc clang format #7677
Add objc clang format #7677
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7677
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit e034624: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base b9a1984:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the yaml checker is tripping. @pmeier any insight? Maybe we should get rid of it if it's becoming unreliable
Kinda surprised that it is picking |
According to the
The hook is configured to trigger on
And indeed $ identify-cli .clang-format
["file", "non-executable", "text", "yaml"] In the YAML specification, each Thus, we have three options:
My preference is 2 > 1 > 3. |
@NicolasHug @pmeier Thanks. Added the option. |
Thanks a lot for the investigation @pmeier . Lint jobs are green so we can merge |
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: vmoens Differential Revision: D47186585 fbshipit-source-id: deb3f62c9fc8c7225054d5a0c843220def2f439b Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Philip Meier <github.pmeier@posteo.de>
The main PR is #7643. Submitting this PR first to get the CI workflows in the main PR run normally without further approval.
cc @NicolasHug @pmeier.