-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simpler file chunking #7673
Simpler file chunking #7673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after https://github.com/pytorch/vision/pull/7673/files#r1233075816 and CI is green. Thanks @adamjstewart!
Could you remove the https://github.com/pytorch/vision/actions/runs/5314674815/jobs/9622150942?pr=7673#step:10:378 |
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de> Reviewed By: vmoens Differential Revision: D47186569 fbshipit-source-id: 5b3a478b538dd52b449c929a995366b85eea8fa5
Now that Python 3.8 is the minimum supported version, we can use the new assignment expression syntax to simplify how we read files chunk-by-chunk. There are many other places where this could be used but they were a bit more complicated so I didn't bother with those.