Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler file chunking #7673

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Simpler file chunking #7673

merged 4 commits into from
Jun 19, 2023

Conversation

adamjstewart
Copy link
Contributor

Now that Python 3.8 is the minimum supported version, we can use the new assignment expression syntax to simplify how we read files chunk-by-chunk. There are many other places where this could be used but they were a bit more complicated so I didn't bother with those.

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 17, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7673

Note: Links to docs will display an error until the docs builds have been completed.

❌ 33 New Failures

As of commit 6bfab3e:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmeier
Copy link
Collaborator

pmeier commented Jun 19, 2023

Could you remove the io import in the relocate.py script?

https://github.com/pytorch/vision/actions/runs/5314674815/jobs/9622150942?pr=7673#step:10:378

@pmeier pmeier merged commit b9a1984 into pytorch:main Jun 19, 2023
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@adamjstewart adamjstewart deleted the utils/chunk branch June 19, 2023 20:47
facebook-github-bot pushed a commit that referenced this pull request Jul 3, 2023
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de>

Reviewed By: vmoens

Differential Revision: D47186569

fbshipit-source-id: 5b3a478b538dd52b449c929a995366b85eea8fa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants