-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused packaging/pkg_helpers.bash, Remove CONDA_CHANNEL_FLAGS #7656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @atalman
Hey @atalman! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
to pytorch/audio
that referenced
this pull request
Jun 6, 2023
Summary: We are using Project Nova workflows now. These are not required. Same as: pytorch/vision#7656 Pull Request resolved: #3409 Reviewed By: mthrok Differential Revision: D46494331 Pulled By: atalman fbshipit-source-id: a642ae55b75482918e0afb7c55dc876bc8356e70
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…EL_FLAGS (#7656) Reviewed By: vmoens Differential Revision: D46724126 fbshipit-source-id: b8be6f2f142e80f41c10c628e9dc397806a33e0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused
CONDA_CHANNEL_FLAGS is not initialized variable. And its not required to install
These libraries should be installed from default channel.
Here is the reference from current workflow:
https://github.com/pytorch/vision/actions/runs/5176600132/jobs/9325627772#step:7:40
Everything is routed via Nova now.