Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont reinstall CUDA in CMake / Windows workflow #7648

Merged
merged 7 commits into from
Jun 5, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 31, 2023

Addresses

# FIXME: Basically, we are reinstalling CUDA here. We only need this, because we need to copy some files that
# can be extracted from the CUDA installer, but are not available on our Windows AMI.
# See https://github.com/pytorch/test-infra/pull/4189
if [[ ${{ matrix.gpu-arch-type }} == cuda ]]; then
export CU_VERSION=cu$(echo ${{ matrix.gpu-arch-version }} | sed 's/\.//')
echo CU_VERSION="${CU_VERSION}"
packaging/windows/internal/cuda_install.bat
fi

This will only work after the deployment of the new Windows AMIs that should happen tomorrow.

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented May 31, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7648

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit f685927:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier marked this pull request as ready for review June 1, 2023 22:10
@pmeier pmeier requested a review from atalman June 1, 2023 22:10
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman atalman merged commit 8835737 into pytorch:main Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Hey @atalman!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the windows-cuda branch June 5, 2023 14:00
facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2023
Summary: Co-authored-by: Andrey Talman <atalman@fb.com>

Reviewed By: vmoens

Differential Revision: D46724122

fbshipit-source-id: 3f602fcbf7be96420502c2c847e29361a742a5df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants