-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only run pyav backend tests for VideoReader if av is available #7641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip, as discussed offline these tests have been skipped forever already.
LGTM if green, ideally with a big disclaimer at the top of this file as a comment like
# WARNING: these tests have been skipped forever on the CI because the video ops are never properly available. This is bad, but things have been in a terrible state for a long time already as we write this comment, and we'll hopefully be able to get rid of this all soon.
I don't mind committing it if you prefer
Please send a commit then. I'll leave merging the PR up to you. |
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
…le (#7641) Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com> Reviewed By: vmoens Differential Revision: D46724118 fbshipit-source-id: 381954d9abe6e930e7a8c15a32f6e8d99b9a26cd
No description provided.