Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run pyav backend tests for VideoReader if av is available #7641

Merged
merged 2 commits into from
May 31, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 30, 2023

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented May 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7641

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures

As of commit d49aeb3:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, as discussed offline these tests have been skipped forever already.

LGTM if green, ideally with a big disclaimer at the top of this file as a comment like

# WARNING: these tests have been skipped forever on the CI because the video ops are never properly available. This is bad, but things have been in a terrible state for a long time already as we write this comment, and we'll hopefully be able to get rid of this all soon. 

I don't mind committing it if you prefer

@pmeier pmeier marked this pull request as ready for review May 31, 2023 11:20
@pmeier
Copy link
Collaborator Author

pmeier commented May 31, 2023

I don't mind committing it if you prefer

Please send a commit then. I'll leave merging the PR up to you.

@NicolasHug NicolasHug merged commit c45f5dc into pytorch:main May 31, 2023
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the videoreader-test branch May 31, 2023 11:47
facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2023
…le (#7641)

Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>

Reviewed By: vmoens

Differential Revision: D46724118

fbshipit-source-id: 381954d9abe6e930e7a8c15a32f6e8d99b9a26cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants