Fix segfault in DeformConv2d when mask is None
#7632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7632
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 241e07d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mask is None
facebook-github-bot
pushed a commit
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a segfault internally on this line:
https://github.com/pytorch/vision/blob/4a51822ca20027b6e03ec4fb582c31cc9545ba4e/torchvision/csrc/ops/cpu/deform_conv2d_kernel.cpp#L224:L224
caused in our tests by this line, i.e. calling the op without a
mask:https://github.com/pytorch/vision/blob/4a51822ca20027b6e03ec4fb582c31cc9545ba4e/test/test_ops.py#L923:L923
I'm not 100% sure whether this sefgault is expected and whether this fix is the "right" one. But it does remove the segfault, and it can't affect the results because of the
use_maskflag which is always False in those calls.