Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update retryable and viable/strict workflows #7628

Merged
merged 2 commits into from
May 25, 2023
Merged

update retryable and viable/strict workflows #7628

merged 2 commits into from
May 25, 2023
+3 −3

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 25, 2023 •
edited by pytorch-bot bot
Loading

@pmeier pmeier requested a review from DanilBaibak May 25, 2023 10:16
@pytorch-bot
Copy link

pytorch-bot bot commented May 25, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7628

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c0eb96e:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier
Copy link
Collaborator Author

pmeier commented May 25, 2023

There is some authorization error when running this on the PR: https://github.com/pytorch/vision/actions/runs/5078796420/jobs/9123764597?pr=7628#step:6:26

@DanilBaibak could you have a look?

DanilBaibak
DanilBaibak approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@DanilBaibak DanilBaibak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanilBaibak
Copy link
Contributor

Hmmm, I checked that the API key exists. There were no changes in the code meanwhile. I guess that there might be some issue while trigger this workflow at the PR level. The changes look correct. Let's merge this PR and follow the workflow.

@pmeier pmeier merged commit 4a51822 into pytorch:main May 25, 2023
@pmeier pmeier deleted the viable-strict-rules branch May 25, 2023 13:02
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request May 31, 2023
@NicolasHug @facebook-github-bot
[fbsync] update retryable and viable/strict workflows (#7628)
b8ec1ad 
Reviewed By: vmoens

Differential Revision: D46314042

fbshipit-source-id: b3b70bd6e99695c7bd54c9371c5386ef5270bf2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanilBaibak DanilBaibak DanilBaibak approved these changes

Assignees
No one assigned
Labels
cla signed module: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @DanilBaibak @facebook-github-bot