-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid _prims_common.check
in favor of torch._check
#7625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kurt! Could you ping me here when the PR on core is merged so I can merge this one as well?
2b92d7c
to
7f22f15
Compare
@pmeier, do you think we could merge this one first? |
Yes, we can do that as well. |
It seems like these CI failures must be unrelated to my changes, right? |
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: vmoens Differential Revision: D46314036 fbshipit-source-id: 8359c4f24f617651ee7aa0f2c08cb11bfa19359a Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>
torch._prims_common.check
will be removed in pytorch/pytorch#102219