Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid _prims_common.check in favor of torch._check #7625

Merged
merged 5 commits into from
May 30, 2023

Conversation

kurtamohler
Copy link
Contributor

torch._prims_common.check will be removed in pytorch/pytorch#102219

@pytorch-bot
Copy link

pytorch-bot bot commented May 25, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7625

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures

As of commit 8ffedd4:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kurt! Could you ping me here when the PR on core is merged so I can merge this one as well?

@kurtamohler kurtamohler force-pushed the update-torch-check branch from 2b92d7c to 7f22f15 Compare May 25, 2023 17:46
@kurtamohler
Copy link
Contributor Author

@pmeier, do you think we could merge this one first? torch._check already exists in pytorch, and having this change in torchvision will fix a CI error I'm getting in the other PR

@pmeier
Copy link
Collaborator

pmeier commented May 26, 2023

Yes, we can do that as well.

@kurtamohler
Copy link
Contributor Author

It seems like these CI failures must be unrelated to my changes, right?

@pmeier pmeier merged commit f36c5de into pytorch:main May 30, 2023
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request May 31, 2023
Reviewed By: vmoens

Differential Revision: D46314036

fbshipit-source-id: 8359c4f24f617651ee7aa0f2c08cb11bfa19359a

Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants